Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cnbBuild) Add support for pre and post-buildpacks #4448

Merged
merged 3 commits into from
Jul 6, 2023
Merged

feat(cnbBuild) Add support for pre and post-buildpacks #4448

merged 3 commits into from
Jul 6, 2023

Conversation

pbusko
Copy link
Member

@pbusko pbusko commented Jul 5, 2023

Changes

  • Tests
  • Documentation

@pbusko
Copy link
Member Author

pbusko commented Jul 5, 2023

/it

@pbusko @modulo11 @c0d1ngm0nk3y
Add pre and post buildpacks
6e54c6a 
Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
@pbusko
Copy link
Member Author

pbusko commented Jul 5, 2023

/it

1 similar comment
@pbusko
Copy link
Member Author

pbusko commented Jul 6, 2023

/it

@c0d1ngm0nk3y @pbusko
fix integration tests
16b2432 
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
@c0d1ngm0nk3y @pbusko
simplify if clauses
d7a6df5 
Co-authored-by: Pavel Busko <[email protected]>
@pbusko
Copy link
Member Author

pbusko commented Jul 6, 2023

/it

@pbusko pbusko marked this pull request as ready for review July 6, 2023 08:33
@pbusko pbusko requested review from a team as code owners July 6, 2023 08:33
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pbusko pbusko merged commit 610e212 into master Jul 6, 2023
11 checks passed
@pbusko pbusko deleted the cnb-pre-post branch July 6, 2023 09:34
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@pbusko @modulo11
@c0d1ngm0nk3y @maxatsap
feat(cnbBuild) Add support for pre and post-buildpacks (SAP#4448)
757e2e7 
* Add pre and post buildpacks

Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>

* fix integration tests

Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>

* simplify if clauses

Co-authored-by: Pavel Busko <[email protected]>

---------

Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0d1ngm0nk3y c0d1ngm0nk3y c0d1ngm0nk3y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbusko @c0d1ngm0nk3y